ulysses-you commented on code in PR #45234:
URL: https://github.com/apache/spark/pull/45234#discussion_r1687324526
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala:
##########
@@ -47,6 +47,15 @@ import org.apache.spark.util.random.XORShiftRandom
*/
trait ShuffleExchangeLike extends Exchange {
+ /**
+ * The asynchronous job that materializes the shuffle. It also does the
preparations work,
+ * such as waiting for the subqueries.
+ */
+ @transient private lazy val shuffleFuture: Future[MapOutputStatistics] =
executeQuery {
+ materializationStarted.set(true)
Review Comment:
It seems not an acutally issue for now. AQE always do materilize stage and
cancel stage at main thread. So if we decide to cancel stage then that means we
will never do materilize stage again. We may need improve this code if we
support do materilize concurrently in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
