davidm-db commented on code in PR #47462:
URL: https://github.com/apache/spark/pull/47462#discussion_r1688161867
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNode.scala:
##########
@@ -155,3 +157,155 @@ abstract class
CompoundNestedStatementIteratorExec(collection: Seq[CompoundState
*/
class CompoundBodyExec(statements: Seq[CompoundStatementExec])
extends CompoundNestedStatementIteratorExec(statements)
+
+/**
+ * Executable node for IfElseStatement.
+ * @param conditions Collection of executable conditions. First condition
corresponds to IF clause,
+ * while others (if any) correspond to following ELSE IF
clauses.
+ * @param bodies Collection of executable bodies.
+ * @param booleanEvaluator Evaluator for Boolean conditions.
+ */
+class IfElseStatementExec(
+ conditions: Seq[SingleStatementExec],
+ bodies: Seq[CompoundBodyExec],
+ booleanEvaluator: StatementBooleanEvaluator) extends NonLeafStatementExec {
+ private object IfElseState extends Enumeration {
+ val Condition, Body = Value
+ }
+
+ private var state = IfElseState.Condition
+ private var curr: Option[CompoundStatementExec] = Some(conditions.head)
+
+ private var clauseIdx: Int = 0
+ private val conditionsCount: Int = conditions.length
+ private val bodiesCount: Int = bodies.length
+ assert(conditionsCount == bodiesCount || conditionsCount + 1 == bodiesCount)
+
+ private lazy val treeIterator: Iterator[CompoundStatementExec] =
+ new Iterator[CompoundStatementExec] {
+ override def hasNext: Boolean = curr.nonEmpty
+
+ override def next(): CompoundStatementExec = state match {
+ case IfElseState.Condition =>
+ assert(curr.get.isInstanceOf[SingleStatementExec])
+ val condition = curr.get.asInstanceOf[SingleStatementExec]
+ if (booleanEvaluator.eval(condition)) {
+ state = IfElseState.Body
+ curr = Some(bodies(clauseIdx))
+ } else {
+ clauseIdx += 1
+ if (clauseIdx < conditionsCount) {
+ // There are ELSE IF clauses remaining.
+ state = IfElseState.Condition
+ curr = Some(conditions(clauseIdx))
+ } else if (conditionsCount < bodiesCount) {
+ // ELSE clause exists.
+ state = IfElseState.Body
+ curr = Some(bodies(clauseIdx))
+ } else {
+ // No remaining clauses.
+ curr = None
+ }
+ }
+ condition
+ case IfElseState.Body =>
+ val retStmt = bodies(clauseIdx).getTreeIterator.next()
+ if (!bodies(clauseIdx).getTreeIterator.hasNext) {
+ curr = None
+ }
+ retStmt
+ }
+ }
+
+ override def getTreeIterator: Iterator[CompoundStatementExec] = treeIterator
+
+ override def reset(): Unit = {
+ state = IfElseState.Condition
+ curr = Some(conditions.head)
+ clauseIdx = 0
+ conditions.foreach(c => c.reset())
+ bodies.foreach(b => b.reset())
+ }
+}
+
+/**
+ * Executable node for WhileStatement.
+ * @param condition Executable node for the condition.
+ * @param body Executable node for the body.
+ * @param booleanEvaluator Evaluator for Boolean condition.
+ */
+class WhileStatementExec(
+ condition: SingleStatementExec,
+ body: CompoundBodyExec,
+ booleanEvaluator: StatementBooleanEvaluator) extends NonLeafStatementExec {
+
+ private object WhileState extends Enumeration {
+ val Condition, Body = Value
+ }
+
+ private var state = WhileState.Condition
+ private var curr: Option[CompoundStatementExec] = Some(condition)
+
+ private lazy val treeIterator: Iterator[CompoundStatementExec] =
+ new Iterator[CompoundStatementExec] {
+ override def hasNext: Boolean = curr.nonEmpty
+
+ override def next(): CompoundStatementExec = {
Review Comment:
you can do directly: `override def next(): CompoundStatementExec = state
match {...}`, outer level of braces is unnecessary...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
