dongjoon-hyun commented on PR #47453: URL: https://github.com/apache/spark/pull/47453#issuecomment-2246697135
Thank you, @HyukjinKwon and @zhengruifeng . I'm +1 for both to have a clear semantic. 1. Using `SparkSession.getDefaultSession` instead of `*OrCreate`. > Alternatively we could use SparkSession.getDefaultSession. 2. Having a clear semantic, `def loadMetadata(path: String, spark: SparkSession, expectedClassName: String = ""): Metadata`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
