cloud-fan commented on code in PR #47404: URL: https://github.com/apache/spark/pull/47404#discussion_r1689241446
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ########## @@ -133,12 +133,42 @@ class AstBuilder extends DataTypeAstBuilder with SQLConfHelper with Logging { private def visitCompoundBodyImpl( ctx: CompoundBodyContext, - label: Option[String]): CompoundBody = { + label: Option[String], + allowVarDeclare: Boolean): CompoundBody = { val buff = ListBuffer[CompoundPlanStatement]() ctx.compoundStatements.forEach(compoundStatement => { buff += visit(compoundStatement).asInstanceOf[CompoundPlanStatement] }) + val compoundStatements = buff.toList + + val candidates = if (allowVarDeclare) { + compoundStatements.dropWhile { + case SingleStatement(_: CreateVariable) => true Review Comment: unrelated question: within SQL scripting, shall we only allow to create single-part-name variables? e.g. should `CREATE VARIABLE system.session.name` be disallowed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org