eason-yuchen-liu commented on code in PR #47425:
URL: https://github.com/apache/spark/pull/47425#discussion_r1690120247
##########
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSerdeSuite.scala:
##########
@@ -228,7 +228,8 @@ object AvroSerdeSuite {
RebaseSpec(CORRECTED),
new NoopFilters,
false,
- "")
+ "",
+ -1)
Review Comment:
Yeah I have thought about it. I did not add default value for two reasons.
First is some newly added options (`stableIdPrefixForUnionType`) did not
specify a default value either. Second is there are two constructors for the
class, one with 5 arguements, the other with 7 arguements, if we were adding
default values for both of them, there will be a clash of definition which is
confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
