anishshri-db commented on code in PR #47133: URL: https://github.com/apache/spark/pull/47133#discussion_r1690818391
########## python/pyspark/sql/pandas/group_ops.py: ########## @@ -93,12 +98,12 @@ def apply(self, udf: "GroupedMapPandasUserDefinedFunction") -> DataFrame: """ # Columns are special because hasattr always return True if ( - isinstance(udf, Column) - or not hasattr(udf, "func") - or ( + isinstance(udf, Column) + or not hasattr(udf, "func") + or ( udf.evalType # type: ignore[attr-defined] != PythonEvalType.SQL_GROUPED_MAP_PANDAS_UDF - ) + ) Review Comment: nit: is the indent ok here ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org