anishshri-db commented on code in PR #47475: URL: https://github.com/apache/spark/pull/47475#discussion_r1690827127
########## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala: ########## @@ -1562,42 +1590,55 @@ abstract class StateStoreSuiteBase[ProviderClass <: StateStoreProvider] } } - test("SPARK-44438: maintenance task should be shutdown on error") { - val conf = new SparkConf() - .setMaster("local") - .setAppName("test") + test("SPARK-48997: maintenance threads with exceptions unload only themselves") { val sqlConf = getDefaultSQLConf( SQLConf.STATE_STORE_MIN_DELTAS_FOR_SNAPSHOT.defaultValue.get, SQLConf.MAX_BATCHES_TO_RETAIN_IN_MEMORY.defaultValue.get ) - // Make maintenance interval small so that maintenance task is called right after scheduling. + // Make maintenance interval small so that maintenance task is called right after scheduling. Review Comment: nit: extra space is a typo ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org