dongjoon-hyun commented on code in PR #23:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/23#discussion_r1690843741
##########
spark-operator/src/main/java/org/apache/spark/k8s/operator/config/SparkOperatorConf.java:
##########
@@ -195,18 +195,18 @@ public class SparkOperatorConf {
.defaultValue(5)
.build();
- public static final ConfigOption<Integer> RETRY_INITIAL_INTERVAL_SECONDS =
+ public static final ConfigOption<Integer>
RECONCILER_RETRY_INITIAL_INTERVAL_SECONDS =
ConfigOption.<Integer>builder()
- .key("spark.kubernetes.operator.retry.initialIntervalSeconds")
+
.key("spark.kubernetes.operator.reconciler.retry.initialIntervalSeconds")
.enableDynamicOverride(false)
.description("Initial interval(in seconds) of retries on unhandled
controller errors.")
.typeParameterClass(Integer.class)
.defaultValue(5)
.build();
- public static final ConfigOption<Double> RETRY_INTERVAL_MULTIPLIER =
+ public static final ConfigOption<Double>
RECONCILER_RETRY_INTERVAL_MULTIPLIER =
ConfigOption.<Double>builder()
- .key("spark.kubernetes.operator.retry.intervalMultiplier")
+ .key("spark.kubernetes.operator.reconciler.retry.intervalMultiplier")
Review Comment:
Thank you for changing the namespace of `retry.*`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
