dusantism-db commented on code in PR #47553: URL: https://github.com/apache/spark/pull/47553#discussion_r1698652131
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ########## @@ -181,10 +183,15 @@ class AstBuilder extends DataTypeAstBuilder with SQLConfHelper if bl.multipartIdentifier().getText.nonEmpty && bl.multipartIdentifier().getText.toLowerCase(Locale.ROOT) != el.multipartIdentifier().getText.toLowerCase(Locale.ROOT) => - throw SqlScriptingErrors.labelsMismatch( - bl.multipartIdentifier().getText, el.multipartIdentifier().getText) + withOrigin(bl) { + throw SqlScriptingErrors.labelsMismatch( + CurrentOrigin.get, bl.multipartIdentifier().getText, el.multipartIdentifier().getText) Review Comment: Sorry, but I dont understand what you mean by this, your suggestion doesn't compile because bl is BeginLabelContext, not Origin, that's why we included withOrigin there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org