attilapiros commented on code in PR #45836:
URL: https://github.com/apache/spark/pull/45836#discussion_r1699239788
##########
core/src/main/scala/org/apache/spark/storage/BlockManager.scala:
##########
@@ -2112,8 +2112,10 @@ private[spark] class BlockManager(
hasRemoveBlock = true
if (tellMaster) {
// Only update storage level from the captured block status before
deleting, so that
- // memory size and disk size are being kept for calculating delta.
- reportBlockStatus(blockId, blockStatus.get.copy(storageLevel =
StorageLevel.NONE))
+ // memory size and disk size are being kept for calculating delta.
Reset the replica
+ // count 0 in storage level to notify that its a remove operation.
Review Comment:
```suggestion
// memory size and disk size are being kept for calculating delta,
but reset the replication
// factor to 0 to indicate its a remove operation.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
