szehon-ho commented on PR #47233: URL: https://github.com/apache/spark/pull/47233#issuecomment-2273902818
Yea makes sense to me, I think the original thought in the comments was that DataFrame is not necessarily a table. By putting it on SparkSession, we could infer in the tableName argument that its for table only. But its true that this is not safer compile-time wise, so probably its better putting the API in the more appropriate place (also where mergeInto is) and leave it to the plan to detect whether it is a table at runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
