mridulm commented on code in PR #47192:
URL: https://github.com/apache/spark/pull/47192#discussion_r1708692450
##########
core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala:
##########
@@ -111,9 +113,22 @@ class TaskMetrics private[spark] () extends Serializable {
* joins. The value of this accumulator should be approximately the sum of
the peak sizes
* across all such data structures created in this task. For SQL jobs, this
only tracks all
* unsafe operators and ExternalSort.
+ * This is not equal to peakOnHeapExecutionMemory +
peakOffHeapExecutionMemory
*/
+ // TODO: SPARK-48789: the naming is confusing since this does not really
reflect the whole
+ // execution memory. We'd better deprecate this once we have a replacement.
def peakExecutionMemory: Long = _peakExecutionMemory.sum
Review Comment:
peakOnHeapExecutionMemory + peakOffHeapExecutionMemory can peak at different
times, so we can't replace it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
