HyukjinKwon commented on code in PR #47402:
URL: https://github.com/apache/spark/pull/47402#discussion_r1708959934


##########
assembly/pom.xml:
##########
@@ -159,6 +159,78 @@
             </target>
           </configuration>
       </plugin>
+      <plugin>
+        <!--
+          Here we download ammonite dependency required for Spark Connect REPL 
and copy
+          Spark Connect client to target's jars/connect-repl directory. Both 
jars will
+          only be loaded when we run Spark Connect shell, see also
+          AbstractCommandBuilder.buildClassPath and SPARK-48936.
+        -->
+        <groupId>org.codehaus.mojo</groupId>
+        <artifactId>exec-maven-plugin</artifactId>
+        <executions>
+          <execution>
+            <id>get-ammonite-jar</id>
+            <phase>package</phase>
+            <goals>
+              <goal>exec</goal>
+            </goals>
+            <configuration>
+              <executable>${basedir}/../build/mvn</executable>

Review Comment:
   That shouldn't be related to the profiles. Let me take a look.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to