MaxGekk commented on code in PR #47354:
URL: https://github.com/apache/spark/pull/47354#discussion_r1711239597


##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -572,6 +572,12 @@
     ],
     "sqlState" : "42703"
   },
+  "COLUMN_VALUE_IS_NULL" : {
+    "message" : [
+      "Value at index <index> is null."

Review Comment:
   ```suggestion
   Found NULL in a row at the index <index>, expected a non-NULL value.
   ```



##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -572,6 +572,12 @@
     ],
     "sqlState" : "42703"
   },
+  "COLUMN_VALUE_IS_NULL" : {

Review Comment:
   Let's name in more precise way:
   ```suggestion
     "ROW_VALUE_IS_NULL" : {
   ```



##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -572,6 +572,12 @@
     ],
     "sqlState" : "42703"
   },
+  "COLUMN_VALUE_IS_NULL" : {
+    "message" : [
+      "Value at index <index> is null."
+    ],
+    "sqlState" : "22000"

Review Comment:
   How about this number "22023"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to