agubichev commented on PR #47673: URL: https://github.com/apache/spark/pull/47673#issuecomment-2278454481
> > Looks good overall. I think we need a couple of tests with just an OFFSET (no LIMIT) > > I think GeneratedSubquerySuite test the situation and compare the result with Postgres. Do we need extra unit test too? Yes, i would add 1-2 tests explicitly in query tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
