viirya commented on code in PR #67: URL: https://github.com/apache/spark-kubernetes-operator/pull/67#discussion_r1721262912
########## spark-operator/build.gradle: ########## @@ -43,10 +43,17 @@ dependencies { implementation("io.dropwizard.metrics:metrics-core:$dropwizardMetricsVersion") implementation("io.dropwizard.metrics:metrics-jvm:$dropwizardMetricsVersion") compileOnly("org.apache.spark:spark-core_$scalaVersion:$sparkVersion") { - exclude group: 'com.squareup.okio' - exclude group: 'com.squareup.okhttp3' + exclude group: "com.github.luben" + exclude group: "io.netty", module: "netty-tcnative-boringssl-static" + exclude group: "io.netty", module: "netty-tcnative-classes" exclude group: "org.apache.logging.log4j" + exclude group: "org.fusesource.leveldbjni" + exclude group: "org.lz4" + exclude group: "org.rocksdb" exclude group: "org.slf4j" + exclude group: "org.xerial.snappy" + exclude group: 'com.squareup.okhttp3' + exclude group: 'com.squareup.okio' Review Comment: Why excluding these transitive dependencies? Aren't they used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org