sunchao commented on code in PR #47800: URL: https://github.com/apache/spark/pull/47800#discussion_r1723546887
########## core/src/main/scala/org/apache/spark/deploy/security/HadoopFSDelegationTokenProvider.scala: ########## @@ -150,6 +150,7 @@ private[deploy] class HadoopFSDelegationTokenProvider val interval = newExpiration - getIssueDate(tokenKind, identifier) logInfo(log"Renewal interval is ${MDC(TOTAL_TIME, interval)} for" + log" token ${MDC(TOKEN_KIND, tokenKind)}") + token.cancel(hadoopConf) Review Comment: nit: could you add some comments here just to make it easier to understand in future? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org