steveloughran commented on code in PR #47795: URL: https://github.com/apache/spark/pull/47795#discussion_r1723680048
########## dev/deps/spark-deps-hadoop-3-hive-2.3: ########## @@ -154,6 +154,9 @@ json4s-scalap_2.13/4.0.7//json4s-scalap_2.13-4.0.7.jar jsr305/3.0.0//jsr305-3.0.0.jar jta/1.1//jta-1.1.jar jul-to-slf4j/2.0.16//jul-to-slf4j-2.0.16.jar +kotlin-stdlib-jdk7/2.0.10//kotlin-stdlib-jdk7-2.0.10.jar +kotlin-stdlib-jdk8/2.0.10//kotlin-stdlib-jdk8-2.0.10.jar +kotlin-stdlib/2.0.10//kotlin-stdlib-2.0.10.jar Review Comment: hadoop uses the v3 mockwebserver in test dependencies only, which also seems to be the only place that koitlin comes in. > it's a little bit crazy to pull another JVM lang runtime into Spark classpath by just consuming an HTTP librar mmm. maybe they've found koitlin a good language for coding; as more projects use then it will becomes less unusual -instead becoming just another dependency pain point à la guava -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
