gengliangwang commented on code in PR #47611:
URL: https://github.com/apache/spark/pull/47611#discussion_r1723899885
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1487,6 +1487,13 @@ object SQLConf {
.intConf
.createWithDefault(200)
+ val DATA_SOURCE_DONT_ASSERT_ON_PREDICATE =
+ buildConf("spark.sql.dataSource.skipAssertOnPredicatePushdown")
+ .internal()
+ .doc("Enable skipping assert when expression in not translated to
predicate.")
+ .booleanConf
+ .createWithDefault(!Utils.isTesting)
Review Comment:
shall we create the default value as false, and then always enable the check
if `Utils.isTesting` is true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
