hkulyc commented on code in PR #47425:
URL: https://github.com/apache/spark/pull/47425#discussion_r1731810938
##########
connector/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala:
##########
@@ -201,29 +259,33 @@ object SchemaConverters {
s,
existingRecordNames,
useStableIdForUnionType,
- stableIdPrefixForUnionType)
-
- val fieldName = if (useStableIdForUnionType) {
- // Avro's field name may be case sensitive, so field names
for two named type
- // could be "a" and "A" and we need to distinguish them. In
this case, we throw
- // an exception.
- // Stable id prefix can be empty so the name of the field
can be just the type.
- val tempFieldName =
s"${stableIdPrefixForUnionType}${s.getName}"
- if
(!fieldNameSet.add(tempFieldName.toLowerCase(Locale.ROOT))) {
- throw new IncompatibleSchemaException(
- "Cannot generate stable identifier for Avro union type
due to name " +
- s"conflict of type name ${s.getName}")
- }
- tempFieldName
+ stableIdPrefixForUnionType,
+ recursiveFieldMaxDepth)
+ if (schemaType == null) {
+ null
} else {
- s"member$i"
- }
+ val fieldName = if (useStableIdForUnionType) {
Review Comment:
Thanks for pointing this out, we currently do not have a test case for this.
Will add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
