MaxGekk commented on code in PR #47818:
URL: https://github.com/apache/spark/pull/47818#discussion_r1732777537
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -3685,7 +3685,7 @@ def regr_avgx(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| 2.75| 2.75|
+---------------+------+
- Example 2: All paris's x values are null
+ Example 2: All pairs's x values are null
Review Comment:
let's be consistent:
```suggestion
Example 2: All pairs' x values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -3926,7 +3926,7 @@ def regr_intercept(y: "ColumnOrName", x: "ColumnOrName")
-> Column:
| 0.0|
+--------------------+
- Example 2: All paris's x values are null
+ Example 2: All pairs's x values are null
Review Comment:
```suggestion
Example 2: All pairs' x values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -4326,7 +4326,7 @@ def regr_syy(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| 5.0|
+--------------+
- Example 2: All paris's x values are null
+ Example 2: All pairs's x values are null
Review Comment:
```suggestion
Example 2: All pairs' x values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -3776,7 +3776,7 @@ def regr_avgy(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| NULL| 1.0|
+---------------+------+
- Example 3: All paris's y values are null
+ Example 3: All pairs's y values are null
Review Comment:
```suggestion
Example 3: All pairs' y values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -3765,7 +3765,7 @@ def regr_avgy(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| 1.75| 1.75|
+---------------+------+
- Example 2: All paris's x values are null
+ Example 2: All pairs's x values are null
Review Comment:
```suggestion
Example 2: All pairs' x values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -4006,7 +4006,7 @@ def regr_r2(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| 1.0|
+-------------+
- Example 2: All paris's x values are null
+ Example 2: All pairs's x values are null
Review Comment:
```suggestion
Example 2: All pairs' x values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -3856,7 +3856,7 @@ def regr_count(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| 0| 1|
+----------------+--------+
- Example 3: All paris's y values are null
+ Example 3: All pairs's y values are null
Review Comment:
```suggestion
Example 3: All pairs' y values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -4177,7 +4177,7 @@ def regr_sxx(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| NULL|
+--------------+
- Example 3: All paris's y values are null
+ Example 3: All pairs's y values are null
Review Comment:
```suggestion
Example 3: All pairs' y values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -4246,7 +4246,7 @@ def regr_sxy(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| 5.0|
+--------------+
- Example 2: All paris's x values are null
+ Example 2: All pairs's x values are null
Review Comment:
```suggestion
Example 2: All pairs' x values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -4017,7 +4017,7 @@ def regr_r2(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| NULL|
+-------------+
- Example 3: All paris's y values are null
+ Example 3: All pairs's y values are null
Review Comment:
```suggestion
Example 3: All pairs' y values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -3937,7 +3937,7 @@ def regr_intercept(y: "ColumnOrName", x: "ColumnOrName")
-> Column:
| NULL|
+--------------------+
- Example 3: All paris's y values are null
+ Example 3: All pairs's y values are null
Review Comment:
```suggestion
Example 3: All pairs' y values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -3845,7 +3845,7 @@ def regr_count(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| 4| 4|
+----------------+--------+
- Example 2: All paris's x values are null
+ Example 2: All pairs's x values are null
Review Comment:
```suggestion
Example 2: All pairs' x values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -4086,7 +4086,7 @@ def regr_slope(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| 1.0|
+----------------+
- Example 2: All paris's x values are null
+ Example 2: All pairs's x values are null
Review Comment:
```suggestion
Example 2: All pairs' x values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -4097,7 +4097,7 @@ def regr_slope(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| NULL|
+----------------+
- Example 3: All paris's y values are null
+ Example 3: All pairs's y values are null
Review Comment:
```suggestion
Example 3: All pairs' y values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -4166,7 +4166,7 @@ def regr_sxx(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| 5.0|
+--------------+
- Example 2: All paris's x values are null
+ Example 2: All pairs's x values are null
Review Comment:
```suggestion
Example 2: All pairs' x values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -3696,7 +3696,7 @@ def regr_avgx(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| NULL| NULL|
+---------------+------+
- Example 3: All paris's y values are null
+ Example 3: All pairs's y values are null
Review Comment:
ok, let's change it then:
```suggestion
Example 3: All pairs' y values are null
```
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -4257,7 +4257,7 @@ def regr_sxy(y: "ColumnOrName", x: "ColumnOrName") ->
Column:
| NULL|
+--------------+
- Example 3: All paris's y values are null
+ Example 3: All pairs's y values are null
Review Comment:
```suggestion
Example 3: All pairs' y values are null
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
