itholic commented on code in PR #47885:
URL: https://github.com/apache/spark/pull/47885#discussion_r1734218031


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -919,6 +919,8 @@ object FunctionRegistry {
   registerInternalExpression[EWM]("ewm")
   registerInternalExpression[NullIndex]("null_index")
   registerInternalExpression[CastTimestampNTZToLong]("timestamp_ntz_to_long")
+  registerInternalExpression[FromProtobuf]("from_protobuf")

Review Comment:
   It seems like the Session extensions is not working from my PR for some 
reason, because `(from|to)_protobuf` are not working when I commented the lines 
here.
   
   (I think I wrongly define the function in 
`InternalFunctionRegistration.scala`. I'm currently trying to fix the 
`ProtoToParsedPlanTestSuite` so let me take a deeper look after resolving this)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to