DennisJLi commented on PR #47914: URL: https://github.com/apache/spark/pull/47914#issuecomment-2315889083
Hi @dongjoon-hyun, good question. I figured it got dropped on the floor, but after doing some git blame investigation. It looks like... 1. Change to set this configuration to true was done in this PR https://github.com/apache/spark/commit/1569ab543d2b560fa8b59ec9df17b3cf76cf1d7f (committed: 2023-08-22) * This would have gone out in 3.5.0 with https://github.com/apache/spark/releases/tag/v3.5.0 (released: 2023-09-08) 2. Change was then undone in this PR https://github.com/apache/spark/commit/ (becc04a9b6e27ffdaf56b35530db1e923254861a, presumably a bad rebase. (committed: 2024-02-07) * This would have gone out in 3.5.1 with https://github.com/apache/spark/releases/tag/v3.5.1 presuming the dates all lined up (2024-02-15) Ideally a patch version wouldn't have reverted this and there wasn't a documentation change, so I think if we just fix this value, then we'd go back to the expected state. What do you think Dongjoon? Also, @ulysses-you , since you did the original change do you have any input here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
