LuciferYang commented on code in PR #47926:
URL: https://github.com/apache/spark/pull/47926#discussion_r1735671468
##########
dev/create-release/release-build.sh:
##########
@@ -536,7 +536,7 @@ if [[ "$1" == "publish-release" ]]; then
file_short=$(echo $file | sed -e "s/\.\///")
dest_url="$nexus_upload/org/apache/spark/$file_short"
echo " Uploading $file_short"
- curl --retry 3 --retry-all-errors -u $ASF_USERNAME:$ASF_PASSWORD
--upload-file $file_short $dest_url
+ curl --retry 3 -u $ASF_USERNAME:$ASF_PASSWORD --upload-file $file_short
$dest_url
Review Comment:
Based on the description from https://github.com/apache/spark/pull/47643,
adding `curl --retry-all-errors` is intended to handle errors like `HTTP 408
Request Timeout`, so it seems necessary. Can we decide whether to add this
option based on the version of `curl`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
