pan3793 commented on code in PR #41782:
URL: https://github.com/apache/spark/pull/41782#discussion_r1735912371
##########
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java:
##########
@@ -53,6 +53,8 @@
public abstract class WritableColumnVector extends ColumnVector {
private final byte[] byte8 = new byte[8];
+ protected abstract void releaseMemory();
Review Comment:
@cloud-fan do we treat `WritableColumnVector` as public api? if so, we
should give it a default implementation instead of abstract method, otherwise,
third-party subclass without implementing this method will be failed with
```
java.lang.AbstractMethodError:
org.apache.spark.sql.execution.vectorized.WritableColumnVector.releaseMemory()V
at
org.apache.spark.sql.execution.vectorized.WritableColumnVector.close(WritableColumnVector.java:92)
at
io.glutenproject.vectorized.ArrowWritableColumnVector.close(ArrowWritableColumnVector.java:362)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
