hvanhovell commented on code in PR #47885:
URL: https://github.com/apache/spark/pull/47885#discussion_r1738525373
##########
connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/ProtobufUtils.scala:
##########
@@ -229,14 +229,18 @@ private[sql] object ProtobufUtils extends Logging {
}
def readDescriptorFileContent(filePath: String): Array[Byte] = {
- try {
- FileUtils.readFileToByteArray(new File(filePath))
- } catch {
- case ex: FileNotFoundException =>
- throw QueryCompilationErrors.cannotFindDescriptorFileError(filePath,
ex)
- case ex: NoSuchFileException =>
- throw QueryCompilationErrors.cannotFindDescriptorFileError(filePath,
ex)
- case NonFatal(ex) => throw
QueryCompilationErrors.descriptorParseError(ex)
+ if (filePath == null || filePath.isEmpty) {
Review Comment:
When does this happen? Would it be a bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
