vicennial commented on code in PR #47930: URL: https://github.com/apache/spark/pull/47930#discussion_r1742662165
########## sql/connect/common/src/main/scala/org/apache/spark/sql/connect/client/ExecutePlanResponseReattachableIterator.scala: ########## @@ -107,7 +107,7 @@ class ExecutePlanResponseReattachableIterator( // Server side session ID, used to detect if the server side session changed. This is set upon // receiving the first response from the server. - private var serverSideSessionId: Option[String] = None + private[connect] var serverSideSessionId: Option[String] = None Review Comment: Could we create a test without requiring an expansion of the scope here? Since it's a `var`, I am a bit uncomfortable having it exposed and open to potential modification -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
