cloud-fan commented on code in PR #47981:
URL: https://github.com/apache/spark/pull/47981#discussion_r1744747037
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalSuite.scala:
##########
@@ -293,4 +293,22 @@ class SimplifyConditionalSuite extends PlanTest with
ExpressionEvalHelper {
Some(Literal.create(null, IntegerType))),
CaseWhen((GreaterThan($"a", 1), Literal.create(1, IntegerType)) :: Nil))
}
+
+ test("accurate") {
+ val nullLiteral = Literal.create(null, BooleanType)
+ val noElseValue = CaseWhen(normalBranch :: trueBranch :: Nil, None)
+ assert(!noElseValue.nullable)
+ val withElseValue = CaseWhen(normalBranch :: trueBranch :: Nil,
Some(Literal(1)))
Review Comment:
let's also test withNullaleElseValue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
