wankunde commented on code in PR #47988: URL: https://github.com/apache/spark/pull/47988#discussion_r1745314113
########## sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java: ########## @@ -72,7 +72,7 @@ public void reset() { numNulls = 0; } - if (hugeVectorThreshold > 0 && capacity > hugeVectorThreshold) { Review Comment: Yes, but `= 0` is not recommended, just keep code and documentation consistent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org