jingz-db commented on code in PR #48000:
URL: https://github.com/apache/spark/pull/48000#discussion_r1746128504
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/state/StatePartitionReader.scala:
##########
@@ -160,32 +165,37 @@ class StatePartitionReader(
override lazy val iter: Iterator[InternalRow] = {
val stateVarName = stateVariableInfoOpt
.map(_.stateName).getOrElse(StateStore.DEFAULT_COL_FAMILY_NAME)
- store
- .iterator(stateVarName)
- .map { pair =>
- stateVariableInfoOpt match {
- case Some(stateVarInfo) =>
- val stateVarType = stateVarInfo.stateVariableType
- val hasTTLEnabled = stateVarInfo.ttlEnabled
-
- stateVarType match {
- case StateVariableType.ValueState =>
- if (hasTTLEnabled) {
- SchemaUtil.unifyStateRowPairWithTTL((pair.key, pair.value),
valueSchema,
- partition.partition)
- } else {
- SchemaUtil.unifyStateRowPair((pair.key, pair.value),
partition.partition)
- }
-
- case _ =>
- throw new IllegalStateException(
- s"Unsupported state variable type: $stateVarType")
- }
-
- case None =>
- SchemaUtil.unifyStateRowPair((pair.key, pair.value),
partition.partition)
+ if (SchemaUtil.isMapStateVariable(stateVariableInfoOpt)) {
+ SchemaUtil.unifyMapStateRowPair(
+ store.iterator(stateVarName), keySchema, partition.partition)
+ } else {
+ store
Review Comment:
Yeah, no change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
