Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/6577#discussion_r31497802
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -80,6 +80,15 @@ abstract class JdbcDialect {
* @return The new JdbcType if there is an override for this DataType
*/
def getJDBCType(dt: DataType): Option[JdbcType] = None
+
+ /**
+ * Enclose column name
+ * @param colName The coulmn name
+ * @return Enclosed column name
+ */
+ def columnEnclosing(colName: String): String = {
+ colName.split('.').map(c => s""""$c"""").mkString(".")
--- End diff --
hmm, can't we have sql like "SELECT column.table FROM table"? I think it is
correct sql query?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
