dillitz commented on code in PR #48122:
URL: https://github.com/apache/spark/pull/48122#discussion_r1762566961
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -2498,7 +2498,7 @@ class SparkConnectPlanner(
if (isCommand) {
// Convert the results to Arrow.
val schema = df.schema
- val maxBatchSize =
(SparkEnv.get.conf.get(CONNECT_GRPC_ARROW_MAX_BATCH_SIZE) * 0.7).toLong
+ val maxBatchSize = (ConnectCommon.CONNECT_GRPC_MAX_MESSAGE_SIZE *
0.7).toLong
Review Comment:
I did not want to change the value for `processAsArrowBatches`, but looking
into it, I think changing the value there makes sense as well since there the
ExecutePlanResponse also only contains the ArrowBatch. So increasing the limit
here to 0.7 * MAX_MESSAGE_SIZE is fine as well. Let's change the config instead
of only the value here then! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
