Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6538#discussion_r31504366
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala ---
@@ -82,6 +82,19 @@ object MLUtils {
val value = indexAndValue(1).toDouble
(index, value)
}.unzip
+
+ // check if indices is one-based and in ascending order
--- End diff --
Yeah, that's fair enough. I don't think this is a performance-critical
block anyway, but the cleverness is probably a step too far in complexity.
This needs a little rebase, and i think you can still use `require` for the
check.
This allows `indices(0) == 0`. Do you mean to initialize `previous = 0`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
