changgyoopark-db commented on PR #48208: URL: https://github.com/apache/spark/pull/48208#issuecomment-2370595119
@juliuszsompolski Hi again! I know... this change is a bit complicated, so I wouldn't urge you to review the code unless you have plenty of free time. To ease reviewing the code, - ExecuteThreadRunner can be in one of the five states below. 1. "notStarted": initial state / can be interrupted / the completion callback will be executed by ExecuteHolder.close. 2. "interrupted": the thread has never been started, and was interrupted / terminal state / the completion callback will be executed by ExecuteHolder.close. 3. "started": the thread is running / can be interrupted / -. 4. "startedInterrupted": the thread is running and interrupted / cannot be completed / the thread executes the completion callback. 5. "completed": the thread will be terminated / terminal state / -. So, 4. "startedInterrupted" is the only state in which ExecuteThreadRunner is allowed to execute the completion callback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
