zhengruifeng commented on code in PR #48256:
URL: https://github.com/apache/spark/pull/48256#discussion_r1776409409


##########
python/pyspark/sql/plot/core.py:
##########
@@ -299,3 +300,28 @@ def area(self, x: str, y: str, **kwargs: Any) -> "Figure":
         >>> df.plot.area(x='date', y=['sales', 'signups', 'visits'])  # 
doctest: +SKIP
         """
         return self(kind="area", x=x, y=y, **kwargs)
+
+    def pie(self, x: str, y: str, **kwargs: Any) -> "Figure":
+        """
+        Generate a pie plot.
+
+        A pie plot is a proportional representation of the numerical data in a

Review Comment:
   nit: should we check the schema before actually computation? e.g. the `y` 
should be a numerical datatype



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to