stevomitric commented on code in PR #48265:
URL: https://github.com/apache/spark/pull/48265#discussion_r1777435118
##########
sql/api/src/main/scala/org/apache/spark/sql/internal/types/AbstractStringType.scala:
##########
@@ -37,7 +37,7 @@ case object StringTypeBinary extends AbstractStringType {
}
/**
- * Use StringTypeBinaryLcase for expressions supporting only binary and
lowercase collation.
+ * Use StringTypeBinaryLcase for expressions supporting only binary and binary
lowercase collation.
Review Comment:
Isn't `binary lowercase` here misleading in a sense that it implies we do
trivial `lower` then binary compare?
##########
sql/api/src/main/scala/org/apache/spark/sql/internal/types/AbstractStringType.scala:
##########
@@ -46,9 +46,10 @@ case object StringTypeBinaryLcase extends AbstractStringType
{
}
/**
- * Use StringTypeAnyCollation for expressions supporting all possible
collation types.
+ * Use StringTypeWithCaseAccentSensitivity for expressions supporting all
collation types
+ * (binary and ICU) but limited to using case and accent sensitivity
specifiers.
*/
-case object StringTypeAnyCollation extends AbstractStringType {
+case object StringTypeWithCaseAccentSensitivity extends AbstractStringType {
Review Comment:
What about pass-through expressions? Shouldn't we keep both names and use
`StringTypeWithCaseAccentSensitivity` for those expressions that we don't have
trim support yet and `StringTypeAnyCollation` for pass-through expressions (as
they won't be affected in the future)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
