fe2s opened a new pull request, #48275:
URL: https://github.com/apache/spark/pull/48275
…idecars
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
When deploying Spark pods on Kubernetes with sidecars, the reported
executor's exit code may be incorrect.
For example, the reported executor's exit code is 0, but the actual is 52
(OOM).
```
2024-09-25 02:35:29,383 ERROR TaskSchedulerImpl:
org.apache.spark.scheduler.TaskSchedulerImpl.logExecutorLoss(TaskSchedulerImpl.scala:972)
- Lost executor 1 on XXXXX: The executor with id 1 exited with exit code
0(success).
The API gave the following container statuses:
container name: fluentd
container image: docker-images-release.XXXXX.com/XXXXX/fluentd:XXXXX
container state: terminated
container started at: 2024-09-25T02:32:17Z
container finished at: 2024-09-25T02:34:52Z
exit code: 0
termination reason: Completed
container name: istio-proxy
container image:
docker-images-release.XXXXX.com/XXXXX-istio/proxyv2:XXXXX
container state: running
container started at: 2024-09-25T02:32:16Z
container name: spark-kubernetes-executor
container image:
docker-dev-artifactory.XXXXX.com/XXXXX/spark-XXXXX:XXXXX
container state: terminated
container started at: 2024-09-25T02:32:17Z
container finished at: 2024-09-25T02:35:28Z
exit code: 52
termination reason: Error
```
The `ExecutorPodsLifecycleManager.findExitCode()` looks for any terminated
container and may choose the sidecar instead of the main executor container.
I'm changing it to look for the executor container always.
Note, it may happen that the pod fails because of the failure of the sidecar
container while executor's container is still running, with my changes the
reported exit code will be -1 (`UNKNOWN_EXIT_CODE`).
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To correctly report executor failure reason on UI, in the logs and for the
event listeners `SparkListener.onExecutorRemoved()`
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, the executor's exit code is taken from the main container instead of
the sidecar.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions
for the consistent environment, and the instructions could accord to:
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Added unit test and tested manually on the Kubernetes cluster by simulating
different types of executor failure (JVM OOM and container eviction due to disk
pressure on the node).
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
