averyqi-db commented on PR #48127: URL: https://github.com/apache/spark/pull/48127#issuecomment-2381069022
@cloud-fan it turns out Analyzer are using different validatePlanChanges implementation only call validateExprIdUniqueness. And this validateSchemaOutput is only used by Optimizer. I think this pr align with our discussion. We'll slack the constraints for optimizer and maintain Analyzer's check. In this case, can we merge the pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
