dongjoon-hyun opened a new pull request, #48550:
URL: https://github.com/apache/spark/pull/48550

   ### What changes were proposed in this pull request?
   
   This PR aims to fix `MasterPage` to hide App UI links when UI is disabled.
   
   Previously, the link leads the following errors if a user clicks it.
   <img width="997" alt="Screenshot 2024-10-17 at 22 06 22" 
src="https://github.com/user-attachments/assets/e53ba01f-533f-4d42-a488-830afaf40efa";>
   
   ### Why are the changes needed?
   
   **1. PREPARATION**
   
   ```
   $ cat conf/spark-defaults.conf
   spark.ui.reverseProxy true
   spark.ui.reverseProxyUrl http://localhost:8080
   
   $ sbin/start-master.sh
   
   $ sbin/start-worker.sh spark://$(hostname):7077
   
   $ bin/spark-shell --master spark://$(hostname):7077 -c spark.ui.enabled=false
   ```
   
   **2. BEFORE**
   
   <img width="340" alt="Screenshot 2024-10-17 at 22 01 16" 
src="https://github.com/user-attachments/assets/3069e43d-ba8c-4d36-8101-65e10b420879";>
   
   **3. AFTER**
   
   <img width="345" alt="Screenshot 2024-10-17 at 22 04 12" 
src="https://github.com/user-attachments/assets/b9feba47-90fb-4557-803c-94eaa8ce62e1";>
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   The previous behavior shows HTTP 500 error.
   
   ### How was this patch tested?
   
   Pass the CIs with a newly added test case.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to