andrej-db commented on code in PR #48621:
URL: https://github.com/apache/spark/pull/48621#discussion_r1816740358
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##########
@@ -219,6 +219,10 @@ protected String inputToSQL(Expression input) {
}
}
+ protected String inputToCaseWhenSQL(Expression input) {
Review Comment:
but then it conflicts with the if (always true)
I think we should keep everything as is (function converts input to CASE
WHEN regardless, it is up to devs to decide when to use it. it is just too much
responsibility to this utility function)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
