Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/6587#issuecomment-108171706 I agree this change can make things simple and actually I have tried to do it before... But think about `AttributeReference.withName`, it won't have effect as the tree node library will regard it as no-change and still keep the old tree. If `AttributeReference` should not care about the `name`, then we need to figure out why we need `AttributeReference.withName`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org