HeartSaVioR commented on code in PR #49091:
URL: https://github.com/apache/spark/pull/49091#discussion_r1884717486
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreChangelog.scala:
##########
@@ -353,7 +353,7 @@ class StateStoreChangelogReaderFactory(
}
protected val input: DataInputStream = decompressStream(sourceStream)
- private def readVersion(): Short = {
+ private lazy val readVersion: Short = {
Review Comment:
nit: it's no longer a method but a value; so probably `version` is the
better name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]