skanderboudawara commented on code in PR #49326: URL: https://github.com/apache/spark/pull/49326#discussion_r1899106300
########## python/pyspark/sql/connect/functions/builtin.py: ########## @@ -339,10 +339,10 @@ def coalesce(*cols: "ColumnOrName") -> Column: coalesce.__doc__ = pysparkfuncs.coalesce.__doc__ -def expr(str: str) -> Column: +def expr(expression: str) -> Column: Review Comment: Hey, I think my decorator needs another update. Since we can deprecate more than one parameter, I’m wondering if it makes sense to use a dictionary or maybe something else. On the consistency side, all the new functions since version 3.3 use “col” instead of “str” for parameters. It feels like harmonizing everything would be a good move, but as you mentioned, it could be a breaking change for folks using keyword arguments. What do you think? Should we wait for more opinions on this topic ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
