WweiL commented on code in PR #49451:
URL: https://github.com/apache/spark/pull/49451#discussion_r1913741479


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala:
##########
@@ -291,7 +291,8 @@ private[sql] class HDFSBackedStateStoreProvider extends 
StateStoreProvider with
       newMap
     }
     catch {
-      case e: SparkException if 
e.getCondition.contains("CANNOT_LOAD_STATE_STORE") =>
+      case e: SparkException
+        if Option(e.getCondition).contains("CANNOT_LOAD_STATE_STORE") =>

Review Comment:
   Thanks for the flagging!
   
   Because of how a StreamingQueryException is constructed:
   
https://github.com/apache/spark/blob/331d0bf30092be62191476e4a679b403e1a369b9/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala#L368
   
   `getCondition` (former `getErrorClass`) from a `StreamingQueryException` 
should always return non-null. So I believe there should never be an NPE 
thrown. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to