ahshahid opened a new pull request, #49521:
URL: https://github.com/apache/spark/pull/49521

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: 
https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a 
faster review.
     7. If you want to add a new configuration, please read the guideline first 
for naming configurations in
        
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the 
guideline first in
        'common/utils/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   The conversion of Hive's timestamp to Catalyst TimestampType needs handling, 
as during hive table metadata reload, the Hive's timestamp gets incorrectly 
mapped to spark's TimestampNTZType, if the timestamp alias is set to 
TimestampNTZType via the conf property spark.sql.timestampType.
   The fix is written keeping in mind, that in future when spark's timestamp 
are mapped correctly with Hive's timestamp, then table reload should not result 
in incorrect TimestampType in spark.
   The changes are that while mapping hive timestamp field to spark's 
StructField, the actual hive's datatype is stored in the metadata of the struct 
field.
   This allows to rectify the table schema by changing the Spark's 
TimestampNTZType back to TimestampType if the original hive datatype is 
"timestamp".
   
   
   ### Why are the changes needed?
   Any table operation which requires reload of table metadata would fail, as 
Hive does not understand spark's TimeStampNTZType.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Added bug test.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to