davidm-db commented on code in PR #49445: URL: https://github.com/apache/spark/pull/49445#discussion_r1925883386
########## sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecution.scala: ########## @@ -55,7 +55,15 @@ class SqlScriptingExecution( } private val variableManager = new SqlScriptingVariableManager(context) - session.sessionState.catalogManager.setSqlScriptingLocalVariableManager(Some(variableManager)) + private val handle = SqlScriptingVariableManager.create(variableManager) Review Comment: nit: I would probably rename this to, at least, `variableManagerHandle`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
