milanisvet commented on code in PR #49518:
URL: https://github.com/apache/spark/pull/49518#discussion_r1928384383
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -274,10 +275,17 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog with QueryErrorsB
checkTrailingCommaInSelect(proj)
case agg: Aggregate =>
checkTrailingCommaInSelect(agg)
+ case unionLoop: UnionLoop =>
+ // Recursive CTEs have already substituted Union to UnionLoop at this
stage.
+ // Here we perform additional checks for them.
+ checkIfSelfReferenceIsPlacedCorrectly(unionLoop)
Review Comment:
But there we come to the problem that we discussed. `Union` won't be
substituted to `UnionLoop` in case we have a self-reference in subquery.
Should I just leave it in `ResolveWithCTE`? Because anyway, the part of
`ResolveWithCTE` I placed it will always be executed at most once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
