HyukjinKwon commented on code in PR #50080:
URL: https://github.com/apache/spark/pull/50080#discussion_r1971095592
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowWriter.scala:
##########
@@ -150,6 +160,13 @@ private[arrow] abstract class ArrowFieldWriter {
valueVector.setValueCount(count)
}
+ def getSizeInBytes(): Int = {
+ valueVector.setValueCount(count)
+ // Before calling getBufferSizeFor, we need to call
+ // `setValueCount`, see
https://github.com/apache/arrow/pull/9187#issuecomment-763362710
+ valueVector.getBufferSizeFor(count)
+ }
Review Comment:
Yeah .. this has been discussed a lot, e.g.,
https://github.com/apache/arrow/pull/9187 but it has been many years in
production without an issue so I assume this is fine ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
