cashmand commented on code in PR #50025:
URL: https://github.com/apache/spark/pull/50025#discussion_r1971807592
##########
common/variant/src/main/java/org/apache/spark/types/variant/VariantShreddingWriter.java:
##########
@@ -283,6 +283,11 @@ private static Object tryTypedShred(
return v.getBinary();
}
break;
+ case UUID:
+ if (targetType instanceof VariantSchema.UuidType) {
Review Comment:
Yes, I included it to simplify future work if we add UUID support to Spark
in the future, or want to expose this library outside of Spark. I don't think
it should be reachable right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
