dongjoon-hyun commented on code in PR #50113:
URL: https://github.com/apache/spark/pull/50113#discussion_r1975674932
##########
project/SparkBuild.scala:
##########
@@ -1002,10 +1002,9 @@ object KubernetesIntegrationTests {
if (excludeTags.exists(_.equalsIgnoreCase("r"))) {
rDockerFile = ""
}
- val extraOptions = if (javaImageTag.isDefined) {
- Seq("-b", s"java_image_tag=$javaImageTag")
- } else {
- Seq("-f", s"$dockerFile")
+ val extraOptions = javaImageTag match {
+ case Some(tag) => Seq("-b", s"java_image_tag=$tag")
+ case _ => Seq("-f", s"$dockerFile")
Review Comment:
Thank you but could you please minimize the patch by removing this
irrelevant style change, `match`, @pan3793 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
